Open
Conversation
gane5hvarma
reviewed
Jan 20, 2026
| return true, nil | ||
| } | ||
|
|
||
| func (ms *manifestStore) Stat(ctx context.Context, dgst digest.Digest) (distribution.Descriptor, error) { |
There was a problem hiding this comment.
i think we can have stat method in our dataplane code instead of distribution repo.
Author
There was a problem hiding this comment.
We can but I thought this would be an apt place to be since all other types have a Stat method but for some reason ManifestService does not.
nmittal-do
reviewed
Jan 20, 2026
| descriptor, err := ms.blobStore.Stat(ctx, dgst) | ||
| if err != nil { | ||
| if err == distribution.ErrBlobUnknown { | ||
| return distribution.Descriptor{}, distribution.ErrManifestUnknownRevision{ |
There was a problem hiding this comment.
Can we add err too to have the stack trace on what happened.
Author
There was a problem hiding this comment.
If we want stack trace, we can add it to data plane code instead of the distribution fork. Better to keep this fork lean and minimal diff with respect to open source's distribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: